[asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

Joshua Colp reviewboard at asterisk.org
Thu Feb 27 14:31:55 CST 2014



> On Feb. 27, 2014, 4:26 p.m., Joshua Colp wrote:
> > This is fine but we should probably do an audit and try to find other cases.
> 
> Corey Farrell wrote:
>     If nobody is working on the audit of channel usage in dialplan functions I can.  Should I start a new JIRA ticket?

That'd be nifty and starting a new JIRA ticket is fine.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3272/#review10972
-----------------------------------------------------------


On Feb. 27, 2014, 3:01 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3272/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 3:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23104
>     https://issues.asterisk.org/jira/browse/ASTERISK-23104
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch prevents a crash when using the function audiohookinheritance without setting the channel.
> 
> 
> Diffs
> -----
> 
>   /branches/11/funcs/func_audiohookinherit.c 409050 
> 
> Diff: https://reviewboard.asterisk.org/r/3272/diff/
> 
> 
> Testing
> -------
> 
> Reporter has tested the patch with successful results.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140227/6f04edf8/attachment.html>


More information about the asterisk-dev mailing list