[asterisk-dev] [Code Review] 3273: Corrected cross-platform stat nanosecond code.

David Lee reviewboard at asterisk.org
Thu Feb 27 11:33:55 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3273/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 11:33 a.m.)


Review request for Asterisk Developers.


Changes
-------

Moved the warning re: not finding a nanoseconds field from config.c to the configure script.


Repository: Asterisk


Description
-------

When nanosecond time resolution was added for identifying config file
changes, it didn't cover all of the myriad of ways that one might obtain
nanosecond time resolution off of struct stat.

Rather than complicate the #if even further figuring out one system from
the next, this patch directly tests for the three struct members I know
about today, and #ifdef's accordingly.


Diffs (updated)
-----

  /branches/1.8/main/config.c 409079 
  /branches/1.8/include/asterisk/autoconfig.h.in 409079 
  /branches/1.8/configure.ac 409079 
  /branches/1.8/configure UNKNOWN 

Diff: https://reviewboard.asterisk.org/r/3273/diff/


Testing
-------

Compiled on Ubuntu 13.10 and OS X 10.9.2.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140227/4a3f0799/attachment.html>


More information about the asterisk-dev mailing list