[asterisk-dev] [Code Review] 3273: Corrected cross-platform stat nanosecond code.

[David Lee]

> On Feb. 27, 2014, 10:48 a.m., rmudgett wrote:
> > /branches/1.8/main/config.c, line 1102
> > <https://reviewboard.asterisk.org/r/3273/diff/1/?file=54883#file54883line1102>
> >
> >     It is acceptable to just set the nanoseconds to zero if the platform doesn't support the resolution.  However, the warning should not be done here.  That warning will cause dev mode to always fail.  The warning should be in the configure log file if it is done anywhere.

I was surprised enough at finding three ways of doing the same thing,
I wanted development builds to blow up if we stumbled upon a fourth.
Probably not the best place to do it here, and there probably are
valid systems that don't support nanosecond times at all.

Moving the warning to the configure script.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3273/#review10973
-----------------------------------------------------------


On Feb. 27, 2014, 10:37 a.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3273/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 10:37 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When nanosecond time resolution was added for identifying config file
> changes, it didn't cover all of the myriad of ways that one might obtain
> nanosecond time resolution off of struct stat.
> 
> Rather than complicate the #if even further figuring out one system from
> the next, this patch directly tests for the three struct members I know
> about today, and #ifdef's accordingly.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/config.c 409079 
>   /branches/1.8/include/asterisk/autoconfig.h.in 409079 
>   /branches/1.8/configure.ac 409079 
>   /branches/1.8/configure UNKNOWN 
> 
> Diff: https://reviewboard.asterisk.org/r/3273/diff/
> 
> 
> Testing
> -------
> 
> Compiled on Ubuntu 13.10 and OS X 10.9.2.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140227/ce56524f/attachment.html>