[asterisk-dev] [Code Review] 3246: res_pjsip_send_to_voicemail: transferring to voicemail for digium phones

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3246/#review10968
-----------------------------------------------------------



asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/sipp/refer.xml
<https://reviewboard.asterisk.org/r/3246/#comment20592>

    What is this in response to?



asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/sipp/refer.xml
<https://reviewboard.asterisk.org/r/3246/#comment20593>

    Where are the 200 OK responses to these NOTIFYs?



asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/test-config.yaml
<https://reviewboard.asterisk.org/r/3246/#comment20591>

    Capital D in Digium.



asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/test-config.yaml
<https://reviewboard.asterisk.org/r/3246/#comment20594>

    If you are only using invite.xml to generate a call, this is more easily accomplished with pluggable_modules.Originator.


You only seem to be using refer.xml and invite.xml in this test. Why are user[123].xml included in this test?

- opticron


On Feb. 20, 2014, 5:01 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3246/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 5:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Testuite test for https://reviewboard.asterisk.org/r/3245/
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/pjsip/tests.yaml 4726 
>   asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/sipp/user3.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/sipp/user2.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/sipp/user1.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/sipp/refer.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/sipp/invite.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/configs/ast1/pjsip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/refer_send_to_vm/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3246/diff/
> 
> 
> Testing
> -------
> 
> Ran test and it passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140227/c84b9f29/attachment-0001.html>