[asterisk-dev] [Code Review] 3261: res_fax: Warn that minrate=2400 is not valid for V.27 instead of failing load

[Matt Jordan]

> On Feb. 25, 2014, 7:23 a.m., Matt Jordan wrote:
> > This was already covered in a previous UPGRADE note as well.
> > 
> > I agree; I'd block changes at trunk.
> 
> Corey Farrell wrote:
>     Since 12.1.0-rc1 has already been released, do I need to do anything special to add this to 12.1.0?  I ask since 12.0.0 allowed minrate=2400, 12.1.0-rc1 doesn't.

You don't - just tag the issue as needing to be released in 12.1.0. I'll get it rolled up into an -rc2 when we make it - there's a few other things that need to be in an -rc2 as well.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3261/#review10945
-----------------------------------------------------------


On Feb. 24, 2014, 5:25 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3261/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:25 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23231
>     https://issues.asterisk.org/jira/browse/ASTERISK-23231
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Change minrate from 2400 to 4800 on config reload in response to changes from ASTERISK-22790 only.  Any config with minrate of 2400 that would fail before r405693 will still fail.
> 
> Comment out many settings in res_fax.conf.sample. The defaults are set in res_fax.c, so setting the same value in sample config does nothing but make the sample config more fragile.
> 
> I'm proposing the changes to res_fax.conf for all branches and trunk.  I believe the changes to res_fax.c should be blocked from trunk.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/res/res_fax.c 408784 
>   /branches/1.8/configs/res_fax.conf.sample 408784 
> 
> Diff: https://reviewboard.asterisk.org/r/3261/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140227/19937790/attachment.html>