[asterisk-dev] [Code Review] 3267: pjsip: avoid edge case potential crash in answer()

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3267/
-----------------------------------------------------------

(Updated Feb. 26, 2014, 12:41 p.m.)


Review request for Asterisk Developers.


Changes
-------

Changed log message as suggested.


Repository: Asterisk


Description
-------

When accidentally compiling asterisk against a rogue pjproject installation that had a slightly different definition pjsip_inv_session structure, the invite_tsx structure could appear null when answer() is called.  This led to a crash because ast_sip_session_send_response would be called with an uninitialized packet.

This patch corrects the uninitialized packet to prevent the crash, and adds a diagnostic message to aid in discovering the cause of the problem (in this case, remove /usr/local/include/pj* to resolve conflicting structure).


Diffs (updated)
-----

  /branches/12/channels/chan_pjsip.c 408931 

Diff: https://reviewboard.asterisk.org/r/3267/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140226/11cb19a0/attachment.html>