[asterisk-dev] [Code Review] 3263: Testsuite: Fix originate-cdr-disposition failure reporting

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3263/#review10943
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Feb. 24, 2014, 6:18 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3263/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 6:18 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23352
>     https://issues.asterisk.org/jira/browse/ASTERISK-23352
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> The test-config.yaml for this test specifies ignore-originate-failure as 'yes' or 'no'.  Both strings evaulate to True, causing all failures to be ignored.
> 
> tests/cdr/cdr-tests.py fails catch the exception thrown by Originate failures.  All exception backtraces are shown, for excepted and unexpected failures.  Additionally test_object.set_pass(False) is never run for unexpected failures, so success is incorrectly reported.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/cdr/originate-cdr-disposition/test-config.yaml 4730 
>   /asterisk/trunk/tests/cdr/cdr-tests.py 4730 
> 
> Diff: https://reviewboard.asterisk.org/r/3263/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140225/e65a5aca/attachment.html>