[asterisk-dev] [Code Review] 3251: res_bucket_sounds: Add 'sounds' URI scheme implementation

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3251/#review10933
-----------------------------------------------------------



/trunk/res/res_bucket_sounds.c
<https://reviewboard.asterisk.org/r/3251/#comment20559>

    Blob.



/trunk/res/res_bucket_sounds.c
<https://reviewboard.asterisk.org/r/3251/#comment20560>

    Blob.



/trunk/res/res_bucket_sounds.c
<https://reviewboard.asterisk.org/r/3251/#comment20562>

    Processing sound description files is a little more complicated than this since continuations need to be accounted for. Examples of this are lyrics-louie-louie and eletelephony in the extra sounds packages.



/trunk/res/res_bucket_sounds.c
<https://reviewboard.asterisk.org/r/3251/#comment20561>

    ast_strip will segfault on NULL input which can happen if the line has no ':'.



/trunk/res/res_bucket_sounds.c
<https://reviewboard.asterisk.org/r/3251/#comment20563>

    Technically true, but the last word should be unloaded


- opticron


On Feb. 23, 2014, 11 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3251/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2014, 11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This module implements a 'sounds' URI scheme which is pretty much a bucket implementation of the core media and sounds indexer. It scans the installed sounds on the system and makes them available via the bucket API. Additional information about the sounds is provided in the form of metadata.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_bucket_sounds.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3251/diff/
> 
> 
> Testing
> -------
> 
> Executed CLI commands, output is as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140224/7aed398b/attachment-0001.html>