[asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

[Matt Jordan]

> On Feb. 11, 2014, 10:54 a.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/hep/hep_capture_node.py, lines 260-261
> > <https://reviewboard.asterisk.org/r/3206/diff/2/?file=53829#file53829line260>
> >
> >     Another place for an enum-style class to be used.

Actually, this one isn't an enum. The HEPv3 protocol specifies that the only valid value for the HEP control portion of the packet are those byte values - the bytes are the values for "HEP3".

I'll add a comment clarifying.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3206/#review10852
-----------------------------------------------------------


On Feb. 11, 2014, 6:22 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3206/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 6:22 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds the following:
> 
> * A pluggable module that emulates a HEP capture server for verifying packets.
> * A function that can, in a rudimentary fashion, verify SIP packets. It's simplistic, but good enough to verify that Asterisk sent the server the SIP message traffic we sent to it from SIPp.
> * A test that verifies that the res_hep/res_hep_pjsip modules forward SIP message traffic to our little capture server.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/tests.yaml 4685 
>   /asterisk/trunk/tests/hep/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/sipp/echo_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/configs/ast1/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/hep_capture_node.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140223/70f507d1/attachment.html>