[asterisk-dev] [Code Review] 3241: Remove extra defines of AST_PBX_MAX_STACK

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3241/#review10916
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Feb. 20, 2014, 5:33 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3241/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 5:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23141
>     https://issues.asterisk.org/jira/browse/ASTERISK-23141
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change ensures AST_PBX_MAX_STACK is only defined in asterisk/pbx.h and asterisk/extconf.h.
> 
> utils/extconf.c never previously included extconf.h.  Once I added the include I found that localized_merge_contexts_and_delete had incorrect parameters.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/utils/extconf.c 408383 
>   /branches/1.8/utils/conf2ael.c 408383 
>   /branches/1.8/res/ael/pval.c 408383 
>   /branches/1.8/main/pbx.c 408383 
> 
> Diff: https://reviewboard.asterisk.org/r/3241/diff/
> 
> 
> Testing
> -------
> 
> Compile only for asterisk.
> 
> ./utils/aelparse ran without failure.  I attempted to run ./utils/conf2ael, but it segfaulted both before and after my patch.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140220/c04f989c/attachment.html>