[asterisk-dev] [Code Review] 3227: alembic: Add missing queue and cdr table creation scripts.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3227/#review10909
-----------------------------------------------------------


I have some general-purpose notes here:

1) Since realtime queues are a configuration replacement, I think that the scripts adding realtime queues should go in the config/ directory instead of its own new directory.
2) This is the first time I've seen booleans used in the alembic script. From a programming perspective, this seems like the correct thing to do. What I'm curious about is whether this is a good idea since most of our documentation shows a yes/no value instead of a true/false value for these options. Since booleans aren't being used in other alembic scripts, their use here is odd.
3) Other alembic scripts have created enums for options that have a limited set of values. This same practice can be applied to certain queue options. For instance, the strategy option could use an enum to limit the choices to the valid ring strategies.

- Mark Michelson


On Feb. 15, 2014, 1:40 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3227/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 1:40 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23233
>     https://issues.asterisk.org/jira/browse/ASTERISK-23233
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Created the queues, queue_members, and cdr alembic scripts.
> 
> The CDR table is more of an example for new setups since the actual table can be fully customized in cdr_adaptive_odbc.conf.
> 
> 
> Diffs
> -----
> 
>   /branches/12/contrib/ast-db-manage/queues/versions/14b983d1bb27_create_queue_tables.py PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/queues/script.py.mako PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/queues/env.py PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/queues.ini.sample PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/cdr/versions/210693f3123d_create_cdr_table.py PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/cdr/script.py.mako PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/cdr/env.py PRE-CREATION 
>   /branches/12/contrib/ast-db-manage/cdr.ini.sample PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3227/diff/
> 
> 
> Testing
> -------
> 
> Created a postgres DB to see that queues and members were read in.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140219/4c17666d/attachment.html>