[asterisk-dev] [Code Review] 3238: Testsuite: Test MWI aggregation

Mark Michelson reviewboard at asterisk.org
Wed Feb 19 16:40:37 CST 2014

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers.

Repository: testsuite


When writing code changes for /r/3237, I wrote this test just to be sure that MWI aggregation worked appropriately. I also realized that there weren't any tests that had multiple PJSUA accounts configured, so a simple test that exercised that would be a good plan.

Of note, I had to make a change to the PJSUA loadable module so that the registration checks were performed in the reactor thread. I was getting a race condition where sometimes the registration from a configured account would not be acknowledged, leading to a reactor timeout. With the changes presented here, the test passed 100% of the time on my box.


  /asterisk/trunk/tests/channels/pjsip/tests.yaml 4701 
  /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/mwi_check.py PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/configs/ast1/modules.conf PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4701 

Diff: https://reviewboard.asterisk.org/r/3238/diff/



Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140219/62ee3bab/attachment.html>

More information about the asterisk-dev mailing list