[asterisk-dev] [Code Review] 3226: channel.c: MOH is not working for transferee after attended transfer

Kevin Harwell reviewboard at asterisk.org
Mon Feb 17 10:26:58 CST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 17, 2014, 10:26 a.m.)

Review request for Asterisk Developers and Olle E Johansson.


Addressed review findings.

Bugs: ASTERISK-19499

Repository: Asterisk


This is a re-post of https://reviewboard.asterisk.org/r/3170/ that has been ported to 1.8.

After acquiring inspiration from Olle's branch and some suggestions from Mark Michelson (see dev list discussion - http://lists.digium.com/pipermail/asterisk-dev/2014-February/065266.html) I updated the code to check to see if MOH is playing on the transferor and if so then start it on the channel that overwrites it during a masquerade.

Example scenario of the problem:
Alice calls Bob and then Bob begins the attended transfer process into a queue.  Upon going on hold Alice hears music and so does Bob once he is in the queue.  Bob then transfers Alice into the queue and then music for Alice stops even though she should be hearing it since has now replaced Bob in the queue.

The problem that was occuring is that once the channel was masqueraded the app (queues, confbridge, etc...) had no way of knowing that the channel had just been swapped out thus it did not start music for the present channel.

Diffs (updated)

  branches/1.8/main/channel.c 408136 
  branches/1.8/channels/chan_sip.c 408136 

Diff: https://reviewboard.asterisk.org/r/3226/diff/


Tested it against queues in 1.8 and queues and confbridges in 11+ and for chan_pjsip in 12.


Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140217/d64a9b65/attachment-0001.html>

More information about the asterisk-dev mailing list