[asterisk-dev] [Code Review] 3221: testsuite: Test for Marked/Normal(Unmarked) user Conference Interaction

Matt Jordan reviewboard at asterisk.org
Mon Feb 17 09:35:22 CST 2014



> On Feb. 17, 2014, 8:39 a.m., opticron wrote:
> > /asterisk/trunk/tests/apps/confbridge/confbridge_marked_unmarked/test-config.yaml, line 158
> > <https://reviewboard.asterisk.org/r/3221/diff/2/?file=53976#file53976line158>
> >
> >     This is MusicOnHoldStart/Stop in later versions of Asterisk.

The problem is that apptest doesn't have a good mechanism to handle min/max versions.

I'd rather have this test verify the state machine in 12, since it's much more likely to get churn in that version. I'll change the minversion of the test to reflect that.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3221/#review10891
-----------------------------------------------------------


On Feb. 15, 2014, 11:01 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3221/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 11:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23198
>     https://issues.asterisk.org/jira/browse/ASTERISK-23198
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test was written by Scott Emidy.
> 
> It continues the ConfBridge state machine tests. In this case, it checks the interactions between marked and normal (unmarked) users
> 
> There are three scenarios:
> 1) Marked user enters first and leaves last.
> 2) Marked user enters first and normal user leaves last, which signifies that a MoH event will be played when the normal user is in a conference alone.
> 3) Normal user enters first and leaves last.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/confbridge/tests.yaml 4701 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_marked_unmarked/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_marked_unmarked/configs/ast1/musiconhold.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_marked_unmarked/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_marked_unmarked/configs/ast1/confbridge.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_marked/configs/ast1/extensions.conf 4701 
> 
> Diff: https://reviewboard.asterisk.org/r/3221/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140217/d9d6b51d/attachment.html>


More information about the asterisk-dev mailing list