[asterisk-dev] [Code Review] 3228: buildsystem: Unbreak the build (infloop) on Asterisk 11+

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3228/
-----------------------------------------------------------

(Updated Feb. 15, 2014, 9:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and Matt Jordan.


Repository: Asterisk


Description
-------

Apparently I broke the build with r408084 ( https://reviewboard.asterisk.org/r/3212/ ).

Reproducing:

  $ touch .cleancount
  $ make
  make[1]: Entering directory `.../asterisk-11.x'
  make[2]: Entering directory `.../asterisk-11.x'
  make[3]: Entering directory `.../asterisk-11.x'
  ...
  <infinite loop here>


  $ touch .lastclean
  $ make
  CC="cc" CXX="" LD="" AR="" RANLIB="" CFLAGS="" LDFLAGS="" make -C menuselect CONFIGURE_SILENT="--silent" makeopts
  make[1]: Entering directory `.../asterisk-11.x/menuselect'
  make[1]: `makeopts' is up to date.
  ...
  <successful build here>
  

There is no problem on 1.8, because it lacks these dependencies on .lastclean:

  menuselect/menuselect: menuselect/makeopts  .lastclean
        +$(MAKE_MENUSELECT) menuselect
  ...
  menuselect/makeopts: makeopts .lastclean
        +$(MAKE_MENUSELECT) makeopts


Obviously the build should be unbroken.

Three options:

(A) I have a super simple patch here that abuses grep to look for the
    MENUSELECT_EMBED= variable here. If you have no grep binary in path,
    it gracefully falls back to the previous behaviour.

(B) We could simply revert.

(C) Someone could try to untangle the .lastclean dependencies. But that
    should probably be after option (B).


(And for options A and B, should they be from 1.8 and up or 11 and up?)


Diffs
-----

  /branches/11/Makefile 408192 

Diff: https://reviewboard.asterisk.org/r/3228/diff/


Testing
-------


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140216/44451bc1/attachment.html>