[asterisk-dev] [Code Review] 3205: Remove PJSIP's MWI-specific function calls

Mark Michelson reviewboard at asterisk.org
Thu Feb 13 12:52:19 CST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 13, 2014, 6:52 p.m.)


This change has been marked as submitted.

Review request for Asterisk Developers.

Repository: Asterisk


This is just to clear up something that's been bothering me for a while now.

PJSIP provides an MWI-specific API that can be used to handle incoming MWI subscriptions. The way we are using it nets us pretty much no benefit at all, and it comes at the expense of having to have odd corner cases in our code for MWI subscriptions.

This patch removes all of PJSIP's MWI library code in favor of generic PJSIP evsub code. This makes the pubsub core code much cleaner, and in my opinion, makes the res_pjsip_mwi.c code more concise.


  /branches/12/res/res_pjsip_pubsub.c 407935 
  /branches/12/res/res_pjsip_mwi.c 407935 

Diff: https://reviewboard.asterisk.org/r/3205/diff/


Ran a manual test with a Digium phone that subscribes to MWI. Tested unsolicited MWI using the testsuite's MWI test.


Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140213/c00693cd/attachment.html>

More information about the asterisk-dev mailing list