[asterisk-dev] [Code Review] 3216: Add SIP User-Agent to contacts

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3216/#review10874
-----------------------------------------------------------


I'd go ahead and add a note to the UPGRADE file that the schema changed to support storing the user agent string.


/branches/12/res/res_pjsip.c
<https://reviewboard.asterisk.org/r/3216/#comment20485>

    Similar to the path option, I would note that this value is stored from the registration, and is not in fact something that would typically be configured (and would be blown away if it was configured).


- Matt Jordan


On Feb. 13, 2014, 12:07 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3216/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 12:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Fairly straightforward patch that reads the SIP User-Agent header from REGISTER requests and stores this value in all contacts that are being bound.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_registrar.c 407957 
>   /branches/12/res/res_pjsip/location.c 407988 
>   /branches/12/res/res_pjsip.c 407957 
>   /branches/12/include/asterisk/res_pjsip.h 407957 
>   /branches/12/contrib/ast-db-manage/config/versions/8b89128752a_add_user_agent.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3216/diff/
> 
> 
> Testing
> -------
> 
> See https://reviewboard.asterisk.org/r/3218/
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140213/80f45bbd/attachment.html>