[asterisk-dev] [Code Review] 3202: install_subst: helper script for installing with path substitution

Tzafrir Cohen reviewboard at asterisk.org
Mon Feb 10 12:46:22 CST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 10, 2014, 6:46 p.m.)

Review request for Asterisk Developers.


Use 'trap' to cleanup on exit, and -e.

Also fix the issues pointed by Corey.

Repository: Asterisk


The Makefile repeats several time installing some scripts with paths (as denoted in __<special name>__) substituted with their actual values.

Substituting this, along with handling the errors correctly, is something that should not be repeated again and again in the makefile. This commit moves it to a single script:

./build_tools/install_subst [-d] <src> <dst>

It installs <src> to <dst> but first substitutes some variables in it. -d (data) installs it as a data file (-m644). Otherwise it is an executable (install's default permissions).

I want this in order to avoid having yet another copy of the above for the systemd unit file (review 3062).

Diffs (updated)

  /trunk/build_tools/install_subst PRE-CREATION 
  /trunk/Makefile 407855 

Diff: https://reviewboard.asterisk.org/r/3202/diff/



Tzafrir Cohen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140210/96420578/attachment.html>

More information about the asterisk-dev mailing list