[asterisk-dev] [Code Review] 3062: a systemd service

[Tzafrir Cohen]

> On Jan. 1, 2014, 4:43 p.m., George Joseph wrote:
> > /trunk/contrib/asterisk.service, line 20
> > <https://reviewboard.asterisk.org/r/3062/diff/2/?file=49947#file49947line20>
> >
> >     I use the following which mimic some of the safe_asterisk settings...
> >     
> >     Nice=0
> >     UMask=0002
> >     LimitCORE=infinity
> >     LimitNOFILE=4096
> >     Restart=always
> >     RestartSec=4
> >     
> >
> 
> jcollie wrote:
>     I don't think that these are appropriate for the default service file.  If you look at the Fedora service file, they are included as comments and can be enabled as needed by the administrator.

of those, Restart = always seems like a good idea. I think it is a sane default. I also reduce RestartSec to 1 (in case Asterisk exists due to e.g. a bad module in the modules directory).

I set the working directory to the varlibdir (normally: /var/lib/asterisk) and thus enable core files (-g) - Asterisk explicitly disables them in the code, which is odd. I still don't touch the limits by default.


- Tzafrir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3062/#review10503
-----------------------------------------------------------


On Feb. 10, 2014, 5:16 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3062/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 5:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Installs a systemd service file for Asterisk.
> 
> Systeemd is the new "one daemon to rule them all" for Linux: http://www.freedesktop.org/wiki/Software/systemd/
> On systems without systemd this should be just a harmless (though maybe annoying) text file.
> 
> This is aimed at replacing safe_asterisk with a more reliable main loop. It almost does that. Is still fails to handle failures, as it seems that systemd's ExecPostStop command does not get the exist status of the stopped command.
> 
> 
> Diffs
> -----
> 
>   /trunk/contrib/scripts/live_ast 407855 
>   /trunk/contrib/scripts/asterisk_cleanup PRE-CREATION 
>   /trunk/contrib/asterisk.service PRE-CREATION 
>   /trunk/Makefile 407855 
> 
> Diff: https://reviewboard.asterisk.org/r/3062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140210/6957d70d/attachment.html>