[asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3155/#review10835
-----------------------------------------------------------

Ship it!


This is good as is.  I just have a minor concern about how spammy the deprecation warning may be.


branches/11/apps/confbridge/conf_config_parser.c
<https://reviewboard.asterisk.org/r/3155/#comment20423>

    This message may be spammy.


- rmudgett


On Feb. 7, 2014, 8:57 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3155/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 8:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: PQ-1396
>     https://issues.asterisk.org/jira/browse/PQ-1396
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently, when the first marked user enters the conference that contains waitmarked users, a prompt is played indicating that the user is being placed into the conference. Unfortunately, this prompt is played to the marked user and not the waitmarked users which is not very helpful.
> 
> This patch changes that behavior to play a prompt stating "The conference will now begin" to the entire conference after adding and unmuting the waitmarked users since the design of confbridge is not conducive to playing a prompt to a subset of users in a conference in an asynchronous manner.
> 
> 
> Diffs
> -----
> 
>   branches/11/configs/confbridge.conf.sample 407622 
>   branches/11/apps/confbridge/include/confbridge.h 407622 
>   branches/11/apps/confbridge/conf_state_multi_marked.c 407622 
>   branches/11/apps/confbridge/conf_state_empty.c 407622 
>   branches/11/apps/confbridge/conf_config_parser.c 407622 
>   branches/11/apps/app_confbridge.c 407622 
>   branches/11/UPGRADE.txt 407622 
> 
> Diff: https://reviewboard.asterisk.org/r/3155/diff/
> 
> 
> Testing
> -------
> 
> Verified that the prompt is heard by users already in the conference when a marked user enters and that ConfBridge tests pass with modified event expectations.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140208/fed9e88d/attachment.html>