[asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

Joshua Colp reviewboard at asterisk.org
Fri Feb 7 14:01:49 CST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 7, 2014, 8:01 p.m.)


This change has been marked as submitted.

Review request for Asterisk Developers.

Repository: Asterisk


The timing API is currently optimized for the case where timing implementations provide a file descriptor and any API invocations directly act on the file descriptor. In practice this turns out to not be the most common case. Timing implementations commonly store a structure with additional information and then have to use a container lookup on any API invocation to get to it.

The attached change removes this container lookup requirement by allowing implementations to store a pointer to their data directly. This removes the container lookup and the world is happier.


  /trunk/res/res_timing_timerfd.c 407425 
  /trunk/res/res_timing_pthread.c 407425 
  /trunk/res/res_timing_kqueue.c 407425 
  /trunk/res/res_timing_dahdi.c 407425 
  /trunk/main/timing.c 407425 
  /trunk/include/asterisk/timing.h 407425 

Diff: https://reviewboard.asterisk.org/r/3175/diff/


Ran the timing test using the various timing implementations on Linux and confirmed they still work. I also placed some calls to a Playback and confirmed it works.


Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140207/3be72055/attachment.html>

More information about the asterisk-dev mailing list