[asterisk-dev] [Code Review] 3194: res_config_pgsql: Fix ast_update2_realtime calls

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3194/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

(1) When doing ast_update2_realtime with res_config_pgsql if you try to set more than one value, you'll be missing a comma. Example:

  PostgreSQL RealTime: Query Failed:
  UPDATE h42_voicemail SET  context='f5f9852e-4ed9-c68d-db13-6fcf044bff42' mailbox='502' WHERE context='f5f9852e-4ed9-c68d-db13-6fcf044bff42' AND mailbox='502'

  added first=0 to get the missing ',' in there

(2) Thread local storage was freed in certain off-nominal code paths.

  removed two ast_free(sql)'s

(3) Moved a few spaces for readability.


Diffs
-----

  /branches/1.8/res/res_config_pgsql.c 407620 

Diff: https://reviewboard.asterisk.org/r/3194/diff/


Testing
-------

No.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140207/587a2fc0/attachment.html>