[asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3178/#review10821
-----------------------------------------------------------



/branches/12/include/asterisk/codec.h
<https://reviewboard.asterisk.org/r/3178/#comment20390>

    These should be documented like a function since they are templates for the functions.



/branches/12/include/asterisk/format_ng.h
<https://reviewboard.asterisk.org/r/3178/#comment20391>

    Same here for the callback functions.



/branches/12/include/asterisk/vector.h
<https://reviewboard.asterisk.org/r/3178/#comment20393>

    This macro also needs a warning that it doesn't handle the case where the position you are inserting is already in use.



/branches/12/main/codec.c
<https://reviewboard.asterisk.org/r/3178/#comment20406>

    You need to use the AO2_ITERATOR_DONTLOCK flag since you have the container locked.



/branches/12/main/codec.c
<https://reviewboard.asterisk.org/r/3178/#comment20395>

    add
    codecs = NULL;



/branches/12/main/codec_builtin.c
<https://reviewboard.asterisk.org/r/3178/#comment20397>

    Is there a
    lpc10_lenght()
    needed?



/branches/12/main/codec_builtin.c
<https://reviewboard.asterisk.org/r/3178/#comment20400>

    get_length missing?



/branches/12/main/codec_builtin.c
<https://reviewboard.asterisk.org/r/3178/#comment20401>

    get_length missing?



/branches/12/main/codec_builtin.c
<https://reviewboard.asterisk.org/r/3178/#comment20402>

    get_length missing?



/branches/12/main/codec_builtin.c
<https://reviewboard.asterisk.org/r/3178/#comment20403>

    get_length missing?



/branches/12/main/codec_builtin.c
<https://reviewboard.asterisk.org/r/3178/#comment20404>

    Is this to be a passthrough codec or is there missing get_samples and get_lenght functions?



/branches/12/main/format_cache.c
<https://reviewboard.asterisk.org/r/3178/#comment20405>

    add
    formats = NULL;


- rmudgett


On Feb. 4, 2014, 9:57 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3178/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 9:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change has a few things in it:
> 
> 1. Some media related things have been moved around to more logical places or their own parts (smoothers).
> 
> 2. A new implementation of media formats according to https://wiki.asterisk.org/wiki/display/AST/Media+Format+Rewrite. The implementation doesn't completely adhere to the design since I tweaked things but it mostly conforms.
> 
> 3. Unit tests for the above implementation.
> 
> What I'd like feedback on is the actual media formats implementation and the API design itself. Is this something you would be comfortable using?
> 
> 
> Diffs
> -----
> 
>   /branches/12/tests/test_format_cap.c PRE-CREATION 
>   /branches/12/tests/test_format_cache.c PRE-CREATION 
>   /branches/12/tests/test_core_format.c PRE-CREATION 
>   /branches/12/tests/test_core_codec.c PRE-CREATION 
>   /branches/12/res/res_rtp_asterisk.c 406006 
>   /branches/12/res/res_fax.c 406006 
>   /branches/12/main/smoother.c PRE-CREATION 
>   /branches/12/main/frame.c 406006 
>   /branches/12/main/format_ng.c PRE-CREATION 
>   /branches/12/main/format_cap_ng.c PRE-CREATION 
>   /branches/12/main/format_cache.c PRE-CREATION 
>   /branches/12/main/format.c 406006 
>   /branches/12/main/codec_builtin.c PRE-CREATION 
>   /branches/12/main/codec.c PRE-CREATION 
>   /branches/12/main/asterisk.c 406006 
>   /branches/12/include/asterisk/vector.h 406006 
>   /branches/12/include/asterisk/smoother.h PRE-CREATION 
>   /branches/12/include/asterisk/frame.h 406006 
>   /branches/12/include/asterisk/format_ng.h PRE-CREATION 
>   /branches/12/include/asterisk/format_cap_ng.h PRE-CREATION 
>   /branches/12/include/asterisk/format_cache.h PRE-CREATION 
>   /branches/12/include/asterisk/format.h 406006 
>   /branches/12/include/asterisk/codec.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3178/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests, all passed.
> 
> Note: I know AO2 throws a fit and it's because a container isn't getting initialized. Getting said container initialized requires beginning the hacking apart process.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140207/7a96b163/attachment-0001.html>