[asterisk-dev] [Code Review] 3183: ARI: pass channel variables into originate as opposed to assigning after originate

[Matt Jordan]

> On Feb. 6, 2014, 3:02 p.m., Corey Farrell wrote:
> > /branches/12/res/ari/resource_channels.c, lines 772-774
> > <https://reviewboard.asterisk.org/r/3183/diff/4/?file=53658#file53658line772>
> >
> >     Why not ast_ari_response_alloc_failed?

I didn't go with that originally, as the caller doesn't really know why it failed, just that it did. As it turns out, the only way it *will* actually fail is due to an allocation error, so that's fine.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3183/#review10806
-----------------------------------------------------------


On Feb. 6, 2014, 1:57 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3183/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 1:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch tweaks the behaviour of POST /channels with channel variables such that the variables are passed into the pbx.c routines that perform the origination. This allows the variables to be assigned to the newly created channels immediately upon their construction, as opposed to be assigned after the originate has completed.
> 
> The upshot of this is that the variables are available on the channels if they execute in the dialplan, as opposed to only being available once the channels are answered.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/ari/resource_channels.c 407562 
> 
> Diff: https://reviewboard.asterisk.org/r/3183/diff/
> 
> 
> Testing
> -------
> 
> Both testsuite originate tests still pass.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140206/21d6efaa/attachment.html>