[asterisk-dev] [Code Review] 3158: indications.conf: fix post-stutter dialtone for in, mx and ph, extra missing stutter

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3158/#review10797
-----------------------------------------------------------

Ship it!


I know that Asterisk will always play the stutter tone on analog ports if there are voicemail messages.  I don't know what the code will do if the stutter tone is not defined.  Play nothing?

This should go into v1.8, v11, v12, and trunk.

- rmudgett


On Feb. 6, 2014, 11:51 a.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3158/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 11:51 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The stutter tone for many (most?) countries in indications.conf is not takes from national/international standards. If there's no alternative definition for a voice mail notification tone, it needs to give a short stutter and then continue with the dial tone.
> 
> In a number of countries it proceeds with a different dial tone. This fixes the definitions of India (in), Mexico (mx) and the Philippines (ph) to proceed with their dial tone, rather than with the us dial tone.
> 
> In addition to that, stutter tones were added to the following zones: Spain (es), Malaysia (my) and Venezuela (ve): I assume that a voicemail notification tone would be useful anywhere. Is that a sane assumption?
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/indications.conf.sample 407571 
> 
> Diff: https://reviewboard.asterisk.org/r/3158/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140206/1b4c10c3/attachment.html>