[asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint <endpoint> shows allow/disallow codecs the same - OPTION 2

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3193/
-----------------------------------------------------------

(Updated Feb. 6, 2014, 12:50 p.m.)


Review request for Asterisk Developers.


Changes
-------

Completed deprecation flag and added an ifdef'd demonstration of how to use this to migrate configuration options in sorcery.

It's my belief that this option is the best way to easily deal with the allow/disallow confusion - and get a new feature in the process.


Bugs: ASTERISK-23092
    https://issues.asterisk.org/jira/browse/ASTERISK-23092


Repository: Asterisk


Description
-------

WAS:

Insert a ! prefix in the display of endpoint disallow value.  Result is:

 disallow                      : !(ulaw|alaw)

NOW:

Remove the disallow option from generated lists, while still accepting it from a configuration file.

This is OPTION 2 - option 1 is https://reviewboard.asterisk.org/r/3136/


Diffs (updated)
-----

  /branches/12/res/res_pjsip_outbound_registration.c 407566 
  /branches/12/res/res_pjsip_endpoint_identifier_ip.c 407566 
  /branches/12/res/res_pjsip_acl.c 407566 
  /branches/12/res/res_pjsip/pjsip_options.c 407566 
  /branches/12/res/res_pjsip/pjsip_configuration.c 407566 
  /branches/12/res/res_pjsip/location.c 407566 
  /branches/12/res/res_pjsip/config_transport.c 407566 
  /branches/12/res/res_pjsip/config_system.c 407566 
  /branches/12/res/res_pjsip/config_global.c 407566 
  /branches/12/res/res_pjsip/config_domain_aliases.c 407566 
  /branches/12/res/res_pjsip/config_auth.c 407566 
  /branches/12/main/sorcery.c 407566 
  /branches/12/main/bucket.c 407566 
  /branches/12/include/asterisk/sorcery.h 407566 

Diff: https://reviewboard.asterisk.org/r/3193/diff/


Testing
-------

Ran command and checked output.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140206/05ce6693/attachment-0001.html>