[asterisk-dev] [Code Review] 3188: format_wav: enhancing log message "Not a wav file" to be clear on what is supported

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3188/#review10771
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Rose


On Feb. 5, 2014, 4:14 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3188/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 4:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22310
>     https://issues.asterisk.org/jira/browse/ASTERISK-22310
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> From Jim's report:
> 
> "The following error message lies. Many things are WAV files which do not contain 1 in the format field.
> 
> if (ltohs(format) != 1) {
> ast_log(LOG_WARNING, "Not a wav file %d\n", ltohs(format));
> 
> Given how unusual the .WAV vs. .wav distinction is I'd go for: "Not a supported wav file format (%d). Only PCM encoded versions are supported with a lower-case '.wav' extension."
> 
> Which would be helpful."
> 
> 
> The message I've suggested in the patch is:
> 
> "Not a supported wav file format (%d). Only PCM encoded, 16 bit, mono, 8kHz files are supported with a lowercase '.wav' extension.\n"
> 
> Please let me know:
> 
> 1) Is the message content accurate according to format_wav.c ?
> 2) Is the message more understandable and less ambiguous than the original?
> 
> 
> Diffs
> -----
> 
>   /branches/12/formats/format_wav.c 407338 
> 
> Diff: https://reviewboard.asterisk.org/r/3188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140205/0e0a96ee/attachment.html>