[asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3185/#review10769
-----------------------------------------------------------



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/3185/#comment20282>

    How are <levels> provided? Space delimited? Comma?
    
    The documentation for this CLI command should make it abundantly clear how to specify the logger levels.



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/3185/#comment20284>

    This should not return NULL. It should iterate over channels that are allowed for deletion.



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/3185/#comment20285>

    This would currently let a user delete a dynamic logger established by a module, i.e., the security logger. That's probably not good.
    
    This should only let the user delete a logger that was previously established via the CLI.



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/3185/#comment20286>

    How would the user have added a log channel to stdout or stderr?


- Matt Jordan


On Feb. 5, 2014, 2:57 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3185/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 2:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1150
>     https://issues.asterisk.org/jira/browse/AST-1150
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds the ability to dynamically add and remove logger channels from Asterisk via the CLI.
> 
> 
> Diffs
> -----
> 
>   trunk/main/logger.c 407459 
> 
> Diff: https://reviewboard.asterisk.org/r/3185/diff/
> 
> 
> Testing
> -------
> 
> Verified that the logs created this way showed up where expected containing the correct logging levels.
> 
> "logger add channel /tmp/testchannel warning,error,verbose,notice"
> "logger remove channel /tmp/testchannel"
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140205/c23e4def/attachment-0001.html>