[asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3175/
-----------------------------------------------------------

(Updated Feb. 5, 2014, 6:17 p.m.)


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

The timing API is currently optimized for the case where timing implementations provide a file descriptor and any API invocations directly act on the file descriptor. In practice this turns out to not be the most common case. Timing implementations commonly store a structure with additional information and then have to use a container lookup on any API invocation to get to it.

The attached change removes this container lookup requirement by allowing implementations to store a pointer to their data directly. This removes the container lookup and the world is happier.


Diffs (updated)
-----

  /trunk/res/res_timing_timerfd.c 407425 
  /trunk/res/res_timing_pthread.c 407425 
  /trunk/res/res_timing_kqueue.c 407425 
  /trunk/res/res_timing_dahdi.c 407425 
  /trunk/main/timing.c 407425 
  /trunk/include/asterisk/timing.h 407425 

Diff: https://reviewboard.asterisk.org/r/3175/diff/


Testing
-------

Ran the timing test using the various timing implementations on Linux and confirmed they still work. I also placed some calls to a Playback and confirmed it works.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140205/a0818cc2/attachment.html>