[asterisk-dev] [Code Review] 3180: Documenation: Configuration section naming in pjsip.conf.sample needs a little clarification

[Mark Michelson]

> On Feb. 4, 2014, 11:35 p.m., Mark Michelson wrote:
> > /branches/12/configs/pjsip.conf.sample, lines 95-98
> > <https://reviewboard.asterisk.org/r/3180/diff/2/?file=53435#file53435line95>
> >
> >     I think that rather than stating that this is how endpoint matching is performed and then later listing the "identify" exception, you should enumerate the ways that Asterisk can match endpoints.
> >     
> >     1) Match a section name for type=endpoint to the user name in the From header of incoming requests
> >     2) Use an identify section to match based on IP address.
> >     
> >     This places like information in the same area.

As a side benefit, this would probably clear up Scott's confusion since it makes it more clear that type=identify is an alternate way to identify an endpoint and has no bearing on AOR matching.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3180/#review10755
-----------------------------------------------------------


On Feb. 4, 2014, 11:12 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3180/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 11:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There is some nuance to naming configuration sections. In the long term I'll hope that configuration section names become a bit more arbitrary; in the short term help me make sure this documentation patch clarifies things.
> 
> 
> Diffs
> -----
> 
>   /branches/12/configs/pjsip.conf.sample 407338 
> 
> Diff: https://reviewboard.asterisk.org/r/3180/diff/
> 
> 
> Testing
> -------
> 
> Only adding informational text to the pjsip.conf.sample file.
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140204/b30b5117/attachment-0001.html>