[asterisk-dev] [Code Review] 3180: Documenation: Configuration section naming in pjsip.conf.sample needs a little clarification

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3180/#review10750
-----------------------------------------------------------



/branches/12/configs/pjsip.conf.sample
<https://reviewboard.asterisk.org/r/3180/#comment20245>

    This isn't accurate.
    
    Username endpoint matching is based on the username in the From header of all incoming SIP requests.
    
    AOR matching on inbound REGSISTER requests is based on the username in the To header of the REGISTER.



/branches/12/configs/pjsip.conf.sample
<https://reviewboard.asterisk.org/r/3180/#comment20247>

    I would not remove this. It's handy to have this explicitly noted.


- Mark Michelson


On Feb. 4, 2014, 9:13 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3180/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 9:13 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There is some nuance to naming configuration sections. In the long term I'll hope that configuration section names become a bit more arbitrary; in the short term help me make sure this documentation patch clarifies things.
> 
> 
> Diffs
> -----
> 
>   /branches/12/configs/pjsip.conf.sample 407338 
> 
> Diff: https://reviewboard.asterisk.org/r/3180/diff/
> 
> 
> Testing
> -------
> 
> Only adding informational text to the pjsip.conf.sample file.
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140204/46bbd3b3/attachment-0001.html>