[asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint <endpoint> shows allow/disallow codecs the same

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3136/
-----------------------------------------------------------

(Updated Feb. 3, 2014, 2:02 p.m.)


Review request for Asterisk Developers.


Changes
-------

After I submitted the last option, I realized several problems with it and a better approach.

This is much cleaner, provides a new OPT_CODEC_HIDDEN_T enum that allows storing of the field but give a null default handler effectively blocking retrieval.


Bugs: ASTERISK-23092
    https://issues.asterisk.org/jira/browse/ASTERISK-23092


Repository: Asterisk


Description
-------

Insert a ! prefix in the display of endpoint disallow value.  Result is:

 disallow                      : !(ulaw|alaw)


Diffs (updated)
-----

  /branches/12/res/res_pjsip/pjsip_configuration.c 407196 
  /branches/12/main/sorcery.c 407196 
  /branches/12/main/config_options.c 407196 
  /branches/12/include/asterisk/config_options.h 407196 

Diff: https://reviewboard.asterisk.org/r/3136/diff/


Testing
-------

Ran command and checked output.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140203/6cbc7d3d/attachment.html>