[asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4280/
-----------------------------------------------------------

(Updated Dec. 31, 2014, 9:10 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Matt's finding.  


Bugs: ASTERISK-24474
    https://issues.asterisk.org/jira/browse/ASTERISK-24474


Repository: Asterisk


Description
-------

General improvements to reliability of conversion utility:

1) track default section of input file to allow parsing an include file that doesn't specify a [section]

2) informatively handle case of assignment with no section

3) correctly handle getting sections from included files

4) assume default bind of 0.0.0.0

5) gracefully handle missing portions of registration string

6) Denote steps of operation and confirm top level conf files being read/written as a convenience


Diffs (updated)
-----

  /branches/12/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py 429613 
  /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py 429613 

Diff: https://reviewboard.asterisk.org/r/4280/diff/


Testing
-------

Ran on config files from various sources to insure no exceptions occurred.  Perused output to confirm appearance of converted input values.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141231/09662112/attachment-0001.html>