[asterisk-dev] [Code Review] 4290: pjsip_options: Fix continued qualifies after endpoint/aor deletion.

[George Joseph]

> On Dec. 23, 2014, 9:46 a.m., Matt Jordan wrote:
> > branches/13/res/res_pjsip/pjsip_options.c, lines 1009-1021
> > <https://reviewboard.asterisk.org/r/4290/diff/1/?file=69977#file69977line1009>
> >
> >     Since we are now removing all qualifies during a reload, do we still need an explicit call to unschedule_qualify on contact creation? We should now be guaranteed on contact creation that, if the contact previously existed, we already destroyed its entry in the scheduler.

Dropped the other review.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4290/#review14038
-----------------------------------------------------------


On Dec. 22, 2014, 11:21 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4290/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2014, 11:21 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If you remove an endpoint/aor from pjsip.conf then do a core reload, qualifies will continue even though the object are gone.  This happens because nothing clears out the qualify tasks.
> 
> This patch unschedules all existing qualify tasks before scheduling new ones on reload.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip/pjsip_options.c 430001 
> 
> Diff: https://reviewboard.asterisk.org/r/4290/diff/
> 
> 
> Testing
> -------
> 
> Verified with Wireshark that the OPTIONS messages stop and ran the testsuite for all pjsip tests and verified that all tests pass.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141223/c8faf97f/attachment.html>