[asterisk-dev] [Code Review] 4289: pjsip_options: Fix duplicate qualify schedules on reload.

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4289/
-----------------------------------------------------------

(Updated Dec. 23, 2014, 9:09 a.m.)


Review request for Asterisk Developers.


Changes
-------

Moved the unschedule so it gets executed even if a schedule isn't.


Repository: Asterisk


Description
-------

Every time you do a core reload, all qualifyable contacts are scheduled again without removing the existing schedule.  So, if you've reloaded 10 times, all contacts will be qualified 11 times in the specified time interval.

This patch just adds an unschedule_qualify before adding the new one.

NB: If a contact unregisters, it was already being cleaned up correctly but if a reload is done and an endpoint/aor is deleted, the contact continues to qualify.  Separate patch coming for that.


Diffs (updated)
-----

  branches/13/res/res_pjsip/pjsip_options.c 430058 

Diff: https://reviewboard.asterisk.org/r/4289/diff/


Testing
-------

Verified with Wireshark that the correct number of OPTIONS messages are being sent after a reload.


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141223/5bcafa6b/attachment.html>