[asterisk-dev] [Code Review] 4272: Testsuite: Verify that bridged channels originated into Stasis and AMI Redirect interoperate properly

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4272/#review14035
-----------------------------------------------------------



asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge_direct_originate/test-config.yaml
<https://reviewboard.asterisk.org/r/4272/#comment24546>

    Which side of the channel is moved into 'default,echo,1'?
    
    When writing a test description, you should be a bit more explicit about what channels are being affected by what actions. It is rather difficult to parse what exactly the test is doing from this description.



asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge_direct_originate/test-config.yaml
<https://reviewboard.asterisk.org/r/4272/#comment24547>

    Somewhere in here, you need to destroy your test bridge. Currently, this test would leak that resource.



asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge_direct_originate/test-config.yaml
<https://reviewboard.asterisk.org/r/4272/#comment24548>

    Minimum version here should be whatever version first contains the patch that fixes the bug this test covers - which should be (I think) 13.2.0.


- Matt Jordan


On Dec. 16, 2014, 2:40 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4272/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 2:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24591
>     https://issues.asterisk.org/jira/browse/ASTERISK-24591
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds a test to verify that the AMI Redirect action can be used in conjunction with channels that have been originated directly into a Stasis() application and are bridged when the Redirect takes place.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/tests.yaml 6119 
>   asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge_direct_originate/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge_direct_originate/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4272/diff/
> 
> 
> Testing
> -------
> 
> Verified that the test operated properly when 4271 was applied and failed when it was not applied.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141223/fcf2033a/attachment.html>