[asterisk-dev] [Code Review] 4292: app_macro: Don't restore the calling location on a channel redirect.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4292/#review14027
-----------------------------------------------------------


You'll need to write a test that verifies this code change.

Note that Kevin just wrote a number of single channel redirect tests (https://reviewboard.asterisk.org/r/4281/) - you can add one for a channel sitting in a Macro that covers this patch.

- Matt Jordan


On Dec. 22, 2014, 7:19 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4292/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2014, 7:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23850
>     https://issues.asterisk.org/jira/browse/ASTERISK-23850
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> v11: If a channel redirect to a macro exten of a macro that is active happens, the redirect location doesn't get executed.  Instead the original macro location is restored and gets reexecuted.
> 
> v13: An additional effect happens if a parked call times out to an extension in the macro that parked the call then the macro is reexecuted instead of the expected park return location.
> 
> * Made not restore the macro calling location on an AST_SOFTHANGUP_ASYNCGOTO.
> 
> * Increased the locked channel range when setting up the macro execution environment to conver things that should be done while the channel is locked.
> 
> * Removed unnecessary NULL tests before calling ast_free() in _macro_exec().
> 
> 
> Diffs
> -----
> 
>   /branches/11/apps/app_macro.c 430058 
> 
> Diff: https://reviewboard.asterisk.org/r/4292/diff/
> 
> 
> Testing
> -------
> 
> On v11, redirected the calling channel to an extension in a macro that dialed the peer.  Before the patch, the peer was hung up and immediately redialed.  With the patch, the expected redirection location in the macro is executed.
> 
> On the v13 version of the patch, the parked call returns to the configured macro extension with the patch.  Without the patch, the call was immediately reparked.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141223/0a91a3b7/attachment.html>