[asterisk-dev] [Code Review] 4230: add capath support to res_pjsip

[Matt Jordan]

> On Dec. 11, 2014, 2:13 p.m., Joshua Colp wrote:
> > trunk/res/res_pjsip/config_transport.c, line 220
> > <https://reviewboard.asterisk.org/r/4230/diff/1/?file=69447#file69447line220>
> >
> >     As this requires a pjproject change this needs a configure check so it can be optional instead of a hard dependency. As it is the build would just fail on an older install.

In addition to Josh's comment, you may want to consider adding a new function to pjproject for this functionality, and leave the signature of pj_ssl_cert_load_from_files as is. That way existing code will continue to compile/link with later versions of pjproject.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4230/#review13949
-----------------------------------------------------------


On Dec. 4, 2014, 4:09 p.m., cloos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4230/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 4:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24575
>     https://issues.asterisk.org/jira/browse/ASTERISK-24575
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Building on the pjproject patch also on bug 24575, support capath for res_pjsip, in parallel to cafile, just like for every other tls subsystem.
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_pjsip/config_transport.c 428862 
>   trunk/res/res_pjsip.c 428862 
>   trunk/include/asterisk/res_pjsip.h 428862 
>   trunk/configs/samples/pjsip.conf.sample 428862 
> 
> Diff: https://reviewboard.asterisk.org/r/4230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cloos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141222/18cc23ef/attachment.html>