[asterisk-dev] [Code Review] 4050: Add ability for Channel Drivers to provide Presence State information

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4050/#review14025
-----------------------------------------------------------

Ship it!


All of the unit tests pass, as well as the SIP presence state functional tests:

=== TEST RESULTS ===

PATH: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

--> tests/channels/SIP/sip_custom_presence/multiple_state_change --- PASSED
--> tests/channels/SIP/sip_custom_presence/nominal_state_change --- PASSED
--> tests/channels/SIP/sip_custom_presence/non_digium_state_change --- PASSED
--> tests/channels/SIP/sip_custom_presence/resubscribe --- PASSED



/trunk/main/presencestate.c
<https://reviewboard.asterisk.org/r/4050/#comment24536>

    A few small red blobs are in the unit test area here; those can get cleaned up on commit.


- Matt Jordan


On Dec. 2, 2014, 10:32 p.m., gareth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4050/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 10:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24363
>     https://issues.asterisk.org/jira/browse/ASTERISK-24363
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds the ability for channel drivers to supply presence information in a similar manner to device state.
> 
> eg: exten => XXX,hint,,<Technology>/<Resource>
> 
> 
> Diffs
> -----
> 
>   /trunk/main/presencestate.c 428167 
>   /trunk/main/pbx.c 428167 
>   /trunk/main/channel.c 428167 
>   /trunk/include/asterisk/channel.h 428167 
> 
> Diff: https://reviewboard.asterisk.org/r/4050/diff/
> 
> 
> Testing
> -------
> 
> Code is originally written as part of ASTERISK-13145 which has undergone extensive testing.
> 
> 
> Thanks,
> 
> gareth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141222/2b4fc85a/attachment.html>