[asterisk-dev] [Code Review] 4288: res_pjsip_phoneprovi_provider: Fix reload

[George Joseph]

> On Dec. 21, 2014, 3:58 p.m., Joshua Colp wrote:
> > branches/13/res/res_pjsip_phoneprov_provider.c, line 357
> > <https://reviewboard.asterisk.org/r/4288/diff/1/?file=69974#file69974line357>
> >
> >     Why are you using this instead of a retrieve_by_fields and AST_RETRIEVE_FLAG_MULTIPLE | AST_RETRIEVE_FLAG_ALL?

Because I keep forgetting I can do that. :)


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4288/#review14022
-----------------------------------------------------------


On Dec. 21, 2014, 3:52 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4288/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2014, 3:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Reloading wasn't working correctly because on a reload, the sorcery apply handler was never being called for unchanged users.  So, instead of using an apply handler, I'm now iterating over all users.  Works much more reliably.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_pjsip_phoneprov_provider.c 429913 
> 
> Diff: https://reviewboard.asterisk.org/r/4288/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141221/26a4e857/attachment.html>