[asterisk-dev] [Code Review] 4281: Testsuite: Single channel redirect tests

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4281/#review14015
-----------------------------------------------------------



/asterisk/trunk/tests/manager/redirect/single/bridge/test-config.yaml
<https://reviewboard.asterisk.org/r/4281/#comment24529>

    On my last review, I noted that I thought that this should be Local/alice.*2$, but you mentioned that this was not correct. I ran the test and figured out what's up.
    
    Origination operates on the ;1 channel, so origination creates the ;1 channel and waits for an answer. The ;2 channel is created to run dialplan. In this case, the ;2 channel goes into alice at default and answers. Origination gets the answer and places the ;1 channel into the call-bob extension. So it makes sense that the ;1 channel is the one to get bridged...



/asterisk/trunk/tests/manager/redirect/single/bridge/test-config.yaml
<https://reviewboard.asterisk.org/r/4281/#comment24530>

    ...which leads me to an actual finding. The purpose of this test is to redirect a channel that's in a bridge. Right now, you're redirecting a channel that is in the Echo application, and that channel happens to be linked via local channel magic to a channel in a bridge.
    
    Change the redirect to move Local/alice at default-00000000;1 instead. You'll also need to change your UserEvent expectation later.


- Mark Michelson


On Dec. 19, 2014, 4:57 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4281/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 4:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24536
>     https://issues.asterisk.org/jira/browse/ASTERISK-24536
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Wrote two tests:
> 
> 1) Redirect a single channel that is in the Echo application, verify that it gets redirected to the appropriate dialplan location, and make sure no surrogate channels are hanging around.
> 
> 2) Redirect a single channel that is in a bridge with another channel, verify that the channel gets redirected to the appropriate dialplan location, and make sure the channel it was bridged with is hung up.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/manager/tests.yaml 6126 
>   /asterisk/trunk/tests/manager/redirect/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/redirect/single/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/redirect/single/bridge/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/redirect/single/bridge/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/manager/redirect/single/app/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/redirect/single/app/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4281/diff/
> 
> 
> Testing
> -------
> 
> Ran tests and they passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141219/4f2ff23d/attachment-0001.html>