[asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

[Kevin Harwell]

> On Dec. 18, 2014, 11:39 a.m., Kevin Harwell wrote:
> > /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py, lines 333-335
> > <https://reviewboard.asterisk.org/r/4280/diff/1/?file=69818#file69818line333>
> >
> >     I believe sections can be defined across multiple includes.  Removing the "for" loop may mean you potentially miss some defined values.

I don't know what I was thinking, but I got that reversed in my head (thinking you had removed the loop), however you are adding it which actually is correct so just drop this issue please.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4280/#review14008
-----------------------------------------------------------


On Dec. 17, 2014, 12:04 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4280/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 12:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24474
>     https://issues.asterisk.org/jira/browse/ASTERISK-24474
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> General improvements to reliability of conversion utility:
> 
> 1) track default section of input file to allow parsing an include file that doesn't specify a [section]
> 
> 2) informatively handle case of assignment with no section
> 
> 3) correctly handle getting sections from included files
> 
> 4) assume default bind of 0.0.0.0
> 
> 5) gracefully handle missing portions of registration string
> 
> 6) Denote steps of operation and confirm top level conf files being read/written as a convenience
> 
> 
> Diffs
> -----
> 
>   /branches/12/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py 429613 
>   /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py 429613 
> 
> Diff: https://reviewboard.asterisk.org/r/4280/diff/
> 
> 
> Testing
> -------
> 
> Ran on config files from various sources to insure no exceptions occurred.  Perused output to confirm appearance of converted input values.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141218/0e4971fa/attachment.html>