[asterisk-dev] [Code Review] 4265: res_pjsip_sdp_rtp: Native RTP bridging is chosen for RTP compatible channels when the DTMF mode is not compatible

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4265/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 9:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 429763


Bugs: ASTERISK-24459
    https://issues.asterisk.org/jira/browse/ASTERISK-24459


Repository: Asterisk


Description
-------

A native rtp bridge was being chosen (it shouldn't have been) when using two pjsip channels with incompatible DTMF modes.  This patch sets the rtp instance property, AST_RTP_PROPERTY_DTMF, for the appropriate DTMF mode(s) for pjsip.  It was not being set before, meaning all DTMF modes for pjsip were being treated as compatible, thus native bridging would be chosen as the bridge type when it shouldn't have been.


Diffs
-----

  branches/13/res/res_pjsip_sdp_rtp.c 429572 

Diff: https://reviewboard.asterisk.org/r/4265/diff/


Testing
-------

Using pjsip, set up two endpoints with incompatible DTMF modes.  After establishing a call between noted, using the CLI, that that a native_rtp bridge was being chosen. After the patch noted the channels were now in a simple bridge.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141218/a6ffbb1b/attachment.html>