[asterisk-dev] [Code Review] 4271: ARI: Allow interoperation of ASYNCGOTO and channels originated to Stasis()

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4271/#review13992
-----------------------------------------------------------



branches/13/res/res_stasis.c
<https://reviewboard.asterisk.org/r/4271/#comment24513>

    Checking twice for PBX is redundant.  Also doing the ast_check_hangup_locked() first is relatively more expensive than the ast_channel_pbx() test.  This could be better written:
    
    if !ast_channel_pbx()
      int chan_hungup
    
      lock_channel
      clear ASYNCGOTO
      chan_hungup = ast_check_hangup()
      unlock_channel
      if !chan_hungup
        run PBX on channel.
    


- rmudgett


On Dec. 17, 2014, 12:30 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4271/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 12:30 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-24591
>     https://issues.asterisk.org/jira/browse/ASTERISK-24591
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When the AMI Redirect action is used with a channel bridged inside Stasis() and not running a pbx, the channel is hung up instead of proceeding to the desired location in dialplan. This change allows such channels to be Redirected properly by detecting the operation used by Redirect (ASYNCGOTO) and using the code already established for functionality of the ARI channel continue operation.
> 
> 
> Diffs
> -----
> 
>   branches/13/res/res_stasis.c 429611 
> 
> Diff: https://reviewboard.asterisk.org/r/4271/diff/
> 
> 
> Testing
> -------
> 
> Ran the test that found this bug and verified that it passed with the expected events. See review 4272 for the test in question.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/8df73ff3/attachment-0001.html>