[asterisk-dev] [Code Review] 4274: Testsuite: Ensure that outbound registrations with bad auth do not result in an infinite loop.

[Mark Michelson]

> On Dec. 16, 2014, 11:36 p.m., Kevin Harwell wrote:
> > /asterisk/trunk/tests/channels/pjsip/registration/outbound/auth_loop/sipp/uas-reg-401.xml, lines 5-7
> > <https://reviewboard.asterisk.org/r/4274/diff/1/?file=69783#file69783line5>
> >
> >     It doesn't look like you are using "rrs", so this comment can be removed.

This is what happens when your scenarios are based on the default UAS scenario in SIPp. I'll remove the comment and also give the scenario a better name.


On Dec. 16, 2014, 11:36 p.m., Mark Michelson wrote:
> > Would it make any sense to check for the AMI Registry event in this scenario?  For instance two registration attempts should raise two Registry events. More than that of course would result in an error.

Sure, I can add that check in pretty easily. Having a closer look, there really should only be a single Registry event issued in this case since receiving the first 401 will not result in a Registry event being emitted.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4274/#review13973
-----------------------------------------------------------


On Dec. 16, 2014, 10:22 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4274/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 10:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is a test for the contents of review 4273.
> 
> This test sets up a SIPp scenario that expects two REGISTER requests to be sent from Asterisk. Each of these REGISTER requests is responded to with a 401. Asterisk should completely cease sending registrations after the second 401 is received. The SIPp scenario stays alive a little after the final 401 is sent to ensure that Asterisk does not send any further REGISTER requests.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/registration/outbound/tests.yaml 6075 
>   /asterisk/trunk/tests/channels/pjsip/registration/outbound/auth_loop/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/outbound/auth_loop/sipp/uas-reg-401.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/outbound/auth_loop/configs/ast1/pjsip.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4274/diff/
> 
> 
> Testing
> -------
> 
> This test fails without the changes from /r/4273. The test succeeds with the changes applied.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/fd99dd03/attachment-0001.html>