[asterisk-dev] [Code Review] 4276: res_pjsip_config_wizard: Update to earlier patch for fix test breakage.

George Joseph reviewboard at asterisk.org
Wed Dec 17 11:24:04 CST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 17, 2014, 10:24 a.m.)

Review request for Asterisk Developers and Joshua Colp.

Repository: Asterisk


The earlier patch fixed the test breakage but caused a problem when res_pjsip_config_wizard is unloaded then loaded again.

When res_pjsip_config_wizard is unloaded, config still has the mtime of pjsip_wizard.conf cached.  When the module is loaded again, a reload of res_pjsip is triggered which causes the observer to do a reload as opposed to a load of the file.  The result is FILEUNCHANGED and the wizard never loads any objects.  The file has to be cached for normal operation so the easiest solution was to expose the config cache_remove function and call it when res_pjsip_config_wizard is unloaded.  Now if res_pjsip_config_wizard is loaded, it gets a good config instead of FILEUNCHANGED even though it's a reload.

Diffs (updated)

  branches/13/res/res_pjsip_config_wizard.c 429698 

Diff: https://reviewboard.asterisk.org/r/4276/diff/


Tested the unloading and re-loading of the module as well as config reload and pjsip reload to make sure the correct objects were updated.


George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/f3c49390/attachment.html>

More information about the asterisk-dev mailing list