[asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

[greenfieldtech]

> On Dec. 16, 2014, 5:01 p.m., Mark Michelson wrote:
> > Hey Nir, I just wanted to see what's going on with this and if we can expect to see a new diff posted any time soon. If you're busy with other things, that's fine, but we'd love to get this merged in sometime soon if we can. If you have other things going on, then someone else can take the reins here and get this done instead.
> 
> greenfieldtech wrote:
>     Hi Mark,
>     
>       Sorry for the delay on this one. Since Mid November it's just been a crazy mad house over here, so I was totally swamped with things. Thanks to Christmas, things are somewhat cooling down, and I'll be able to finish this. Technically speaking, the initial diff does much of the works,
>     just need to make it a little more orderly.
>     
>     Nir

Btw, 

Just my imagination, or trunk had changes for the "originate" method of ARI? it made the patch much simpler. 

Currently, the patch will work like this:

1. Check if label was provided - if provided, it will supersede priority.
2. If a numeric value is provided in "label", it will be interpreted as a priority as well (dual purpose - so that we can deprecate "priority" in ARI 2)
3. If no label provided and priority is provided, use priority.

I will be uploading my patch once a I verify working condition.

Nir


- greenfieldtech


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4101/#review13964
-----------------------------------------------------------


On Nov. 5, 2014, 2:16 p.m., greenfieldtech wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4101/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 2:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24412
>     https://issues.asterisk.org/jira/browse/ASTERISK-24412
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch changes the current behavior of ARI, to allow channel originate/continue requests to be performed with labels as the priority, not only integer values.
> 
> 
> Diffs
> -----
> 
>   /trunk/rest-api/api-docs/channels.json 425359 
>   /trunk/res/res_ari_channels.c 425359 
>   /trunk/res/ari/resource_channels.c 425359 
>   /trunk/res/ari/resource_channels.h 425359 
> 
> Diff: https://reviewboard.asterisk.org/r/4101/diff/
> 
> 
> Testing
> -------
> 
> Testing was performed by testing the following scenarios:
> 1. Originating a call to a numeric priority - works
> 2. Originating a call to a null priority - works
> 3. Originating a call to a label - works
> 4. Continue a call to a label - not tested yet
> 
> 
> Thanks,
> 
> greenfieldtech
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/3c17963c/attachment.html>