[asterisk-dev] [Code Review] 4275: config: make config_cache_remove public as ast_config_cache_remove

George Joseph reviewboard at asterisk.org
Tue Dec 16 19:17:53 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4275/
-----------------------------------------------------------

Review request for Asterisk Developers and Joshua Colp.


Repository: Asterisk


Description
-------

This patch makes config_cache_remove public as ast_config_cache_remove.  I ran into an issue when unloading and loading res_pjsip_config_wizard where config was caching the last time pjsip_wizard.conf was read.  When res_pjsip_config_wizard was loaded again, it triggers a res_pjsip reload so the res_pjsip_config_wizard observer got FILEUNCHANGED instead of a valid config.  The result was that it didn't load anything.  The config file needs to be cached for normal operation so I can't use NOCACHE but just exposing the cache_remove function and calling it on module unload works perfectly.


Diffs
-----

  branches/13/tests/test_config.c 429672 
  branches/13/main/config.c 429672 
  branches/13/include/asterisk/config.h 429672 

Diff: https://reviewboard.asterisk.org/r/4275/diff/


Testing
-------

Added a unit test for the exposed function and ran the existing config unit tests.


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/450cfcb0/attachment.html>


More information about the asterisk-dev mailing list