[asterisk-dev] [Code Review] 4270: testsuite: Allow tests to specify multiple minimum versions

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4270/#review13976
-----------------------------------------------------------



/asterisk/trunk/lib/python/asterisk/test_config.py
<https://reviewboard.asterisk.org/r/4270/#comment24492>

    This should be: 
    
    minversion = properties.get("minversion", ["1.4"])
    
    as list comprehension initializer expects minversion to be a list of strings.



/asterisk/trunk/lib/python/asterisk/test_config.py
<https://reviewboard.asterisk.org/r/4270/#comment24494>

    Was there a reason the line formatting (the way "expect_pass" is broken up) changed?  Seems a little harder to read imo.


- Kevin Harwell


On Dec. 16, 2014, 1:38 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4270/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 1:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Prior to this patch, a test could only provide a single required minimum version of Asterisk. This doesn't bode well for tests that have been added due to bugs, which typically require a minimum version for each active branch of Asterisk. Not allowing multiple minimum versions to be specified would result in the test being erroneously executed for higher branches of Asterisk, resulting in false test failures.
> 
> Take, for example, tests/channels/SIP/no_ack_dialog_cleanup. This test was added for ASTERISK-20784, the fix of which was released in 1.8.32.0, 11.14.0, 12.7.0, and 13.0.0-beta3. Because only a single version could be specified, however, the best the test writer could do was provide the 1.8 version:
> 
> properties:
>    minversion: '1.8.32.0'
> 
> This would prevent 1.8.31.0 from running against the test, but 11.13.0 would execute the test, as it is greater than the supplied minversion of 1.8.32.0.
> 
> However, if we specify a list of minversions:
> 
>   minversion: ['1.8.32.0', '11.14.0', '12.7.0', '13.0.0-beta3']
> 
> Then we can determine that 11.13.0 is less than 11.14.0, and prevent the test from running.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/test-config.yaml 6106 
>   /asterisk/trunk/tests/channels/SIP/invite_retransmit/test-config.yaml 6106 
>   /asterisk/trunk/runtests.py 6105 
>   /asterisk/trunk/lib/python/asterisk/test_config.py 6105 
> 
> Diff: https://reviewboard.asterisk.org/r/4270/diff/
> 
> 
> Testing
> -------
> 
> Tested that:
> 
> 1.8.31.0, 11.6-cert (branch), 11.6-cert8, and 13.0.0-beta2 won't run the two tests modified in this patch
> 1.8.32.0, 11.14.0, 13 (branch) will run the two tests modified in this patch
> Versions outputted from the '-l' option appear to be correct for all versions listed above
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/0e8664f6/attachment-0001.html>