[asterisk-dev] [Code Review] 4262: bridge: channel ref leak on blond_nonfinal_enter

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4262/
-----------------------------------------------------------

(Updated Dec. 16, 2014, 3:09 p.m.)


Review request for Asterisk Developers.


Changes
-------

Added comment explaining the change.


Bugs: ASTERISK-24513
    https://issues.asterisk.org/jira/browse/ASTERISK-24513


Repository: Asterisk


Description
-------

After a blond transfer to a destination that then hangs up, the Local;1 channel would suffer a reference leak.  This was due to blond_nonfinal_enter() resetting the props->transfer_target to NULL as it unref'd the channel for itself, later preventing the attended_transfer_properties_destructor() from releasing it's own reference, which was inherited during ast_bridge_impart with INDEPDENDENT.

This change prevents props->transfer_target from being set to NULL, and thus eliminates the leak.


Diffs (updated)
-----

  /branches/12/main/bridge_basic.c 429516 

Diff: https://reviewboard.asterisk.org/r/4262/diff/


Testing
-------

Newly created test 'atxfer_fail_blonde' (https://reviewboard.asterisk.org/r/4256/) now passes.  No other new test failures encountered.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141216/f5e912e6/attachment.html>